Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ledger support for eth_getEncryptionPublicKey #16716

Closed
wants to merge 6 commits into from
Closed

feat: add ledger support for eth_getEncryptionPublicKey #16716

wants to merge 6 commits into from

Conversation

justingreenberg
Copy link

@justingreenberg justingreenberg commented Nov 28, 2022 •
edited by brad-decker
Loading

Explanation

Ledger has added support for eth_getEncryptionPublicKey and eth_decrypt (see link below)

It is no longer necessary to reject newRequestEncryptionPublicKey if keyring type is ledger

see: LedgerHQ/app-ethereum#189

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@justingreenberg justingreenberg requested a review from a team as a code owner November 28, 2022 20:00
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@justingreenberg
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@seongyun-ko
Copy link

Hi @pedronfigueiredo, could we get your review :D

Thanks!

@brad-decker
Copy link
Contributor

@seongyun-ko and @justingreenberg -- it appears there is a rebase issue or something as it shows 0 lines of change

@justingreenberg
Copy link
Author

@seongyun-ko and @justingreenberg -- it appears there is a rebase issue or something as it shows 0 lines of change

thanks for flagging, should be resolved @brad-decker

@brad-decker
Copy link
Contributor

Is there a specific version of ledger firmware/ethereum app that supports vs doesnt support method? Will it fail on devices who havent updated?

@justingreenberg
Copy link
Author

PR: LedgerHQ/app-ethereum#240
Release: https://github.com/LedgerHQ/app-ethereum/releases/tag/1.9.18

@brad-decker Supported in Ledger since 1.9.18 (April 22) assuming older versions do not support this method

@Gudahtt
Copy link
Member

Gudahtt commented Feb 15, 2023

I would expect that we'd need to update our Ledger keyring to support this first. I don't see this method on the keyring.

@montelaidev montelaidev mentioned this pull request Feb 27, 2023
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo Awaiting requested review from pedronfigueiredo pedronfigueiredo is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justingreenberg @seongyun-ko @brad-decker @Gudahtt @darkwing